opentelemetry-ruby
opentelemetry-ruby copied to clipboard
Better: remove restrictions on koala.
Following https://github.com/arsduo/koala/issues/659 and the recent release of koala https://github.com/arsduo/koala/pull/663, restrictions on koala and faraday can be removed
- :x: - Yoann Lecuyer The commit (0e16a5e605726b7d60f15d1b7b60df0f3a7813ce ,777e8f9e7d42793b42102cfb0f68a154cee02f47 ,caf421c714cd6742b646b8fb67179f21329f4f06) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.
@ylecuyer hey ,sorry been a bit underwater, not sure why the CLA isn't taking, mind pushing an empty commit to kick the CLA check?
Hello, and thank you for your contribution!
We recently split Ruby instrumentation out into the opentelemetry-ruby-contrib
repo.
This PR is related to instrumentation, so we'll need you to re-open it against opentelemetry-ruby-contrib
. Sorry for the inconvenience!
To do that, you can:
-
Create a fork of
opentelemetry-ruby-contrib
and copy the git url - In your
opentelemetry-ruby
repo, rungit remote add tmp-contrib <your-fork-git-url>
-
git push tmp-contrib your-branch-name
- Open a new PR in contrib (feel free to just copy/paste your original PR description there)
- Close your open PR in this repo with a comment that links to your new PR in contrib
- Delete your
tmp-contrib
remote fromopentelemetry-ruby
(git remote rm tmp-contrib
) -
git clone
youropentelemetry-ruby-contrib
fork, check out your branch, and make all changes in that repo from now on!
Sorry again for the inconvenience, and thank you for contributing!
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep
label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot
👋 Hi, @ylecuyer! Thank you for your PR!
As Sam mentioned, Ruby instrumentation now lives in the opentelemetry-ruby-contrib repo. We'd be happy to take another look at your work in that context.
Since this PR is focused on instrumentation, I'm going to close it.
We appreciate your contribution and hope to work with you again soon!