opentelemetry-ruby icon indicating copy to clipboard operation
opentelemetry-ruby copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Add debugging info during Zipkin export

Open andrewhood125 opened this issue 2 years ago • 6 comments

Recently ran into an issue trying to integrate Zipkin and used this to help identify the issue.

After Screen Shot 2022-01-03 at 4 14 37 PM

andrewhood125 avatar Jan 04 '22 00:01 andrewhood125

CLA Signed

The committers are authorized under a signed CLA.

  • :white_check_mark: Andrew Hood (8977842fb488dc978c8f1e247c55a56b4576a602)

linux-foundation-easycla[bot] avatar Jan 04 '22 00:01 linux-foundation-easycla[bot]

Thanks for the context, I haven't looked at the OTLP exporter but I will. I think logging for non success is the right way to go I've updated the PR.

andrewhood125 avatar Jan 10 '22 07:01 andrewhood125

Feedback addressed, thanks for the review!

andrewhood125 avatar Jan 10 '22 22:01 andrewhood125

@andrewhood125 (rubocop complaining about rubocop things)

ericmustin avatar Jan 11 '22 16:01 ericmustin

@ericmustin I believe this is ready to go now!

andrewhood125 avatar Jan 25 '22 21:01 andrewhood125

@andrewhood125 yup, lgtm and i've approved, cc @open-telemetry/ruby-maintainers

ericmustin avatar Jan 25 '22 22:01 ericmustin