opentelemetry-ruby-contrib icon indicating copy to clipboard operation
opentelemetry-ruby-contrib copied to clipboard
verified publisher icon open-telemetry

feat: Skip Trilogy`ping` span with option `ping_enabled`

Open TonyCTHsu opened this issue 1 year ago • 4 comments

closes #842

Trilogy: Add an configuration option ping_enabled to skip ping instrumentation

TonyCTHsu avatar Mar 05 '24 23:03 TonyCTHsu

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

github-actions[bot] avatar May 02 '24 01:05 github-actions[bot]

👋 Hi @TonyCTHsu! It looks like there are two comments in the PR blocking further review:

Let us know if you have any follow-up questions!

kaylareopelle avatar May 13 '24 15:05 kaylareopelle

I think we had a similar discussion where we decided to reject a similar PR for PostgreSQL

@robertlaurin suggested using custom samplers instead:

https://github.com/open-telemetry/opentelemetry-ruby-contrib/pull/955

arielvalentin avatar May 13 '24 17:05 arielvalentin

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot

github-actions[bot] avatar Jun 13 '24 01:06 github-actions[bot]