opentelemetry-ruby-contrib
opentelemetry-ruby-contrib copied to clipboard
open-telemetry
Missing instrumentation of Net::LDAP
Not a bug, more a feature request.
At the moment Net::LDAP is not instrumented. As the login outcome and duration are often interesting to detect issues, it would be really nice to have this instrumented as well.
We have very limited capacity and are in need of some additional instrumentation maintainers to help.
Would you be interested in contributing and maintaining this instrumentation?
@jdehaan is that instrumented already somewhere (like DataDog, NewRelic, Elastic APM)? That could make it easier to introduce this by porting.
I can look into it, we are starting a migration to opentelemetry. At the moment I do not know how others do, I just noticed the expected traces to the authentication service didn't show up on our setup and wanted to remedy to it. I think I could provide a contribution based on how Net::HTTP is done, as it looks to me quite similar.
👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
We are experimenting a solution available here: https://github.com/tools-aoeur/opentelemetry-ruby-contrib/pull/2. It is in an early stage. Tests are not yet provided in a sufficient amount for instance.
Do you think the code looks well enough to initiate a PR here so it becomes more visibility?
PS: in the meanwhile we improved the state and merged inside our fork, we are testing this productively
👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.
Hi @jdehaan , I think the solution in https://github.com/tools-aoeur/opentelemetry-ruby-contrib/pull/2 looks great. Would you mind open the PR here and we can start the review.
