opentelemetry-ruby-contrib icon indicating copy to clipboard operation
opentelemetry-ruby-contrib copied to clipboard

Add Missing AWS Resource Detectors

Open NathanielRN opened this issue 2 years ago • 3 comments

Description

NOTE: We should block on open-telemetry/opentelemetry-ruby-contrib#33 before addressing this issue because the Resource Detectors should go in the same opentelemetry-sdk-extension-aws gem as the ID Generator.

We should add Resource Detectors to automatically populate the resource.* attributes of all spans in certain attributes. For example, if an app is running on EC2, users should be able to use the OpenTelemetry EC2 Resource Detector to automatically populate information about the EC2 instance they are running on.

Resource Detectors already exist in several other OTel Languages:

OTel Java:

OTel Python

These languages have resource detectors, but put them in separate packages:

OTel Go:

OTel JS:

.NET has all X-Ray necessary components in one package, but should split the propagator out eventually

OTel .NET

The X-Ray team would be happy to help contribute these in the near future! 🙂

NathanielRN avatar Jan 25 '22 22:01 NathanielRN

Hi, I would love to help by contributing resource detectors for AWS EC2, ECS and Lambda as part of this issue. Let me know if can raise a PR.

khyatigandhi6 avatar Mar 14 '22 04:03 khyatigandhi6

Thanks @khyatigandhi6! I'm sure I would be able to find people on the AWS to help review 🙂 However, we should block this issue and resolve open-telemetry/opentelemetry-ruby-contrib#33 first. Would you be willing to take that issue on?

NathanielRN avatar Mar 14 '22 23:03 NathanielRN

Hey @NathanielRN, Currently I don't have much knowledge and hands-on related to X-ray ID-generators. But I will have a look at it and will definitely take up that issue, if I find something around it :)

khyatigandhi6 avatar Mar 15 '22 07:03 khyatigandhi6

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

github-actions[bot] avatar Apr 27 '23 01:04 github-actions[bot]