opentelemetry-python icon indicating copy to clipboard operation
opentelemetry-python copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Relax protobuf version requirement to support v6

Open bouk opened this issue 6 months ago • 6 comments

Fixes https://github.com/open-telemetry/opentelemetry-python/issues/4563, see that issue for details

bouk avatar Jun 06 '25 09:06 bouk

@emdneto I think running the workflows requires approval, are you able to do that?

bouk avatar Jun 10 '25 09:06 bouk

I am not the maintainer or even contributor, but based on the upgrading flow to protobuf 5 there was a statement that OTEL desired to support only 1 version of protobuf, no? I hope it will be protobuf 6 soon 🎉

The statement appeared in this issue/comment: https://github.com/open-telemetry/opentelemetry-python/issues/3958#issuecomment-2153046108

sshishov avatar Jun 10 '25 13:06 sshishov

I am not the maintainer or even contributor, but based on the upgrading flow to protobuf 5 there was a statement that OTEL desired to support only 1 version of protobuf, no? I hope it will be protobuf 6 soon 🎉

The statement appeared in this issue/comment: #3958 (comment)

Yes, I think this is the general agreement from the SIG.

@bouk I mean, update the test-requirements.txt and run the tests.

emdneto avatar Jun 10 '25 23:06 emdneto

@emdneto done, and the tests pass

bouk avatar Jun 12 '25 07:06 bouk

Hi team, I don't know if you are aware of this https://nvd.nist.gov/vuln/detail/CVE-2025-4565

iblancasa avatar Jun 17 '25 09:06 iblancasa

I have time for this tomorrow, sure.

bouk avatar Jun 19 '25 17:06 bouk

there was a statement that OTEL desired to support only 1 version of protobuf, no? I hope it will be protobuf 6 soon 🎉

The statement appeared in this issue/comment: #3958 (comment)

This is no longer relevant see my comment on https://github.com/open-telemetry/opentelemetry-python/issues/4639#issuecomment-2997003823. This PR looks is the correct approach

aabmass avatar Jun 23 '25 15:06 aabmass

I have time for this tomorrow, sure.

Did you already start on this? If not, I already have a fix I can push.

aabmass avatar Jun 23 '25 16:06 aabmass

@emdneto PTAL, I added separate tox targets for oldest+latest supported dependencies for opentelemetry-proto and opentelemetry-exporter-otlp-proto-grpc, generated with uv pip compile.

aabmass avatar Jun 24 '25 04:06 aabmass

Please someone push a changelog :)

xrmx avatar Jun 24 '25 09:06 xrmx

Hello everyone! Is this scheduled for release? If so, is there an ETA?

I could take advantage of this fix

Thanks in advance!

jmezzera avatar Jul 03 '25 16:07 jmezzera