opentelemetry-python
opentelemetry-python copied to clipboard
open-telemetry
Add `exporter/opentelemetry-exporter-otlp-proto-grpc` to the pyright include list. Fix all lint errors in that package.
Description
Add exporter/opentelemetry-exporter-otlp-proto-grpc to the pyright include list. Fix all lint errors in that package.
Type of change
Please delete options that are not relevant.
- [x ] Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Unit tests all pass
Does This PR Require a Contrib Repo Change?
- [ ] Yes. - Link to PR:
- [ x] No.
Checklist:
- [x ] Followed the style guidelines of this project
- [x ] Changelogs have been updated
- [ x] Unit tests have been added
- [x ] Documentation has been updated
Not sure why that docs check is failing..
You are exporting more stuff and so something must be added to the sphinx ignore list
Aha didn't know about the sphinx ignore list thanks.
What do you think of adding ExportStubT as a public symbol ? I can underscore it, but it'd be inconsistent with the existing variable names
BTW I bumped pyright up to ==1.1.400 here to get rid of the warning message asking us to upgrade it... Didn't cause any issues AFAICT...
Alright I think it's good to go now.. The changing public symbols are all in the exporter mixin class, which I think it's doubtful people are using directly..