opentelemetry-python
opentelemetry-python copied to clipboard
OTEL_*_EXPORT_TIMEOUT should do something
Currently it doesn't do anything. This was uncovered in https://github.com/open-telemetry/opentelemetry-python/pull/4535.
Need to figure out how it should behave when the OTLP exporter(s) already had it's export timeout flag set via another env var.
@DylanRussell
Does this apply to the other batch span/metric processors too?
Yeah good question, same exact issue for the Batch span processor.
I'm pretty sure also an issue on the metric processor, it gets passed through to collect, and I'm not sure where collect is implemented.. But the metric exporter doesn't do anything with it's timeout param, so even if it's getting passed through to that it's not being used there.
Yeah confirming it's also an issue on the metrics processor. https://github.com/open-telemetry/opentelemetry-python/blob/main/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/export/init.py#L476 - it gets set here, and ultimately gets passed all the way into export where it gets ignored, for both gRPC and HTTP exporters:
https://github.com/open-telemetry/opentelemetry-python/blob/main/exporter/opentelemetry-exporter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/metric_exporter/init.py#L161
https://github.com/open-telemetry/opentelemetry-python/blob/main/exporter/opentelemetry-exporter-otlp-proto-http/src/opentelemetry/exporter/otlp/proto/http/metric_exporter/init.py#L212C9-L212C23