opentelemetry-python icon indicating copy to clipboard operation
opentelemetry-python copied to clipboard
verified publisher icon open-telemetry

Fix Resource constructor examples

Open xrmx opened this issue 7 months ago • 6 comments

We have in comments and in code wrong example of Resource construction. The final resource sent to tracers, meters and loggers should be created with Resource.create and not by instantiating a Resource instance. In tests we may be more lenient since we don't care much what's there but in examples it should be correct.

See https://github.com/open-telemetry/opentelemetry.io/issues/6549

xrmx avatar Apr 17 '25 07:04 xrmx

Hi. I'd like to work on this issue. Please assign it to me. Thanks

petertamuk avatar Apr 17 '25 13:04 petertamuk

Hi @xrmx, I’m interested in contributing and noticed this issue hasn’t had recent activity. If the current assignee is no longer working on it, I’d be glad to take it up and open a PR soon. Please let me know. Thanks!

Sanket-0510 avatar May 10 '25 16:05 Sanket-0510

planning to pick this up over the weekend, as there hasn’t been any activity on it for the past month.

amitalokbera avatar Jun 27 '25 18:06 amitalokbera

planning to pick this up over the weekend, as there hasn’t been any activity on it for the past month.

Hey, pardon me for being inactive over this issue. I have almost fixed the issue, I'll try to close this by tomorrow.

Sanket-0510 avatar Jun 27 '25 20:06 Sanket-0510

looks like this issue has not been closed yet, I am open to contribute to this issue.

Player2898 avatar Jul 19 '25 02:07 Player2898

This issue should be closed, if you look at the example it now shows the correct usage:

Image

jscancella avatar Jul 25 '25 22:07 jscancella