opentelemetry-python icon indicating copy to clipboard operation
opentelemetry-python copied to clipboard

Run tests in Python 3.13

Open antonpirker opened this issue 1 year ago • 4 comments

Description

In this PR we run the tests suite against Python 3.13 to see if this works.

I know this is not something we can merge yet, because we probably have to wait until the final Python 3.13 is released. But this PR should be a starting point to see what still needs to be done to make opentelementry-python compatible with Python 3.13.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

I ran all the test suites using tox against Python 3.13 locally. One is still failing:

  py313-test-opentelemetry-api: commands succeeded
  py313-test-opentelemetry-proto-0: commands succeeded
  py313-test-opentelemetry-proto-1: commands succeeded
  py313-test-opentelemetry-sdk: commands succeeded
  py313-test-opentelemetry-semantic-conventions: commands succeeded
ERROR:   py313-test-opentelemetry-getting-started: parallel child exit code 1
  py313-test-opentelemetry-opentracing-shim: commands succeeded
  py313-test-opentelemetry-opencensus-shim: commands succeeded
  py313-test-opentelemetry-exporter-opencensus: commands succeeded
  py313-test-opentelemetry-exporter-otlp-proto-common-0: commands succeeded
  py313-test-opentelemetry-exporter-otlp-proto-common-1: commands succeeded
  py313-test-opentelemetry-exporter-otlp-combined: commands succeeded
  py313-test-opentelemetry-exporter-otlp-proto-grpc-0: commands succeeded
  py313-test-opentelemetry-exporter-otlp-proto-grpc-1: commands succeeded
  py313-test-opentelemetry-exporter-otlp-proto-http-0: commands succeeded
  py313-test-opentelemetry-exporter-otlp-proto-http-1: commands succeeded
  py313-test-opentelemetry-exporter-prometheus: commands succeeded
  py313-test-opentelemetry-exporter-zipkin-combined: commands succeeded
  py313-test-opentelemetry-exporter-zipkin-proto-http: commands succeeded
  py313-test-opentelemetry-exporter-zipkin-json: commands succeeded
  py313-test-opentelemetry-propagator-b3: commands succeeded
  py313-test-opentelemetry-propagator-jaeger: commands succeeded
  py313-test-opentelemetry-test-utils: commands succeeded

But I guess this is because I need to set CONTRIB_REPO_SHA to a commit in the contrib repo that has the Python 3.13 changes in it (which is not possible, because I forked the contrib repo)

Does This PR Require a Contrib Repo Change?

  • [x] Yes. - Link to PR: https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2724
  • [ ] No.

Checklist:

  • [ ] Followed the style guidelines of this project
  • [ ] Changelogs have been updated
  • [x] Unit tests have been added
  • [ ] Documentation has been updated

antonpirker avatar Jul 22 '24 08:07 antonpirker

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: antonpirker / name: Anton Pirker (2e08a910bc7ebb5e0004e5a1cff65d9a2c940731, 20dc2b0fd3c802007a073167ccdb127995b3c7e0, 6eb32ae29df4dd253ab9868f0ef8405c20bd0502, 2bf39f36fb953a8a19a59b4d284ffc27269fc047, d10e0c839f8c820acfeb70e0c1ad11f4a0b17040, 5138447e4a7dcfad77ebf38ba981049ab40115cf, ee71a5c37d985c78ecb70e545ba979015908d17a, 12ef0b75660c77b09ba69d5f75417a897c038d5c, c4d5b6c45fb4afa78f0ce09b7b075303a2039ecc)
  • :white_check_mark: login: xrmx / name: Riccardo Magliocchetti (7adfb2a742c5230eefde376a275519a34359444d)

Currently the show blocker is, that grpcio does not yet support Python 3.13. But will do so by the end of September 2024, see this comment: https://github.com/grpc/grpc/issues/34922#issuecomment-2234243059

antonpirker avatar Aug 05 '24 13:08 antonpirker

Seems like grpc support for 3.13 has been released: https://github.com/grpc/grpc/issues/34922#issuecomment-2380652812

alexmojaki avatar Oct 08 '24 16:10 alexmojaki

Seems like grpc support for 3.13 has been released: grpc/grpc#34922 (comment)

@antonpirker is there any other blocker for this PR to make it ready for review?

emdneto avatar Oct 14 '24 19:10 emdneto