opentelemetry-python icon indicating copy to clipboard operation
opentelemetry-python copied to clipboard

Fix: Don't pass ns for ms in timeout during metrics collection

Open martin-schulze-e2m opened this issue 8 months ago • 7 comments

Description

When nearing the collection deadline, the remaining time should be accurately passed is timeout to the callbacks. Once the deadline is closer than 10s, the remaining time in nanoseconds is passed to timeout_millis, which is expected to be in milliseconds, thus giving a timeout that is 10e6 times too large.

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

CI?

Does This PR Require a Contrib Repo Change?

No. (As far as I can tell.)

Checklist:

  • [ ] Followed the style guidelines of this project
  • [ ] Changelogs have been updated
  • [ ] Unit tests have been added
  • [ ] Documentation has been updated

martin-schulze-e2m avatar Jun 10 '24 10:06 martin-schulze-e2m