opentelemetry-python icon indicating copy to clipboard operation
opentelemetry-python copied to clipboard

Attempted to add traceback.format_exc() to solve issue with exceptions

Open kennykguo opened this issue 1 year ago • 5 comments

Attempted to add traceback.format_exc() to solve issue with exceptions.

Fixes #2683

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. Added small try and except, and new line of code to log the exceptions for debugging purposes

Fixes # (issue) Implemented exception debugging

Type of change

Added try and except block

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration According to replication of the issue, and tests by the issuer, the issuer describes an error in passing exceptions during exception handling. The original issue can be found here: https://github.com/open-telemetry/opentelemetry-python/issues/2683

  • [ ] Test A

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • [ ] Yes. - Link to PR:

  • [ x ] No.

Checklist:

  • [ ] Followed the style guidelines of this project
  • [ ] Changelogs have been updated
  • [ ] Unit tests have been added
  • [ ] Documentation has been updated

kennykguo avatar Jan 24 '24 01:01 kennykguo

This would be a bugfix and thus, need a CHANGELOG entry.

ocelotl avatar Feb 10 '24 03:02 ocelotl

Please make the title of this PR more descriptive of the issue being fixed.

ocelotl avatar Feb 10 '24 03:02 ocelotl

I made the corresponding changelog entry here - https://github.com/open-telemetry/opentelemetry-python/commit/4079a3c5c71ebee8c12f11ea41de9d659668e16f

kennykguo avatar Feb 28 '24 03:02 kennykguo

Please always run tox before submitting a PR. I am marking this PR as draft, mark it as ready for review when you have a PR that passes the basic tests.

ocelotl avatar Feb 29 '24 15:02 ocelotl

This PR needs changes that prove they are solving the issue, marking it as draft until this has been done.

ocelotl avatar Mar 14 '24 22:03 ocelotl