opentelemetry-python-contrib icon indicating copy to clipboard operation
opentelemetry-python-contrib copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Starlette instrumentation tests fail recent versions `starlette >= 0.15.0`

Open aabmass opened this issue 8 months ago • 3 comments
trafficstars

Originally posted by @aabmass in https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3304#discussion_r1972595732

Only really ancient versions of starlette seem to be working with opentelemetry-insturmentation-starlette. The tests fail if you increase the version range because of an issue with capturing custom headers. See thread for more context.

aabmass avatar Feb 28 '25 19:02 aabmass

The reason is that we adopted anyio in Starlette on that version.

That said, I don't think it makes sense to maintain <0.15, nor anything close to that. 0.15.0 is from June 23, 2021. In the ASGI ecosystem, that is pretty old already.

Kludex avatar Feb 28 '25 20:02 Kludex

I agree we should increase the minimum version. Is this something you'd be willing to work on?

aabmass avatar Mar 03 '25 18:03 aabmass

I don't think I'll have time soon. If someone else wants to try, I can review it. Otherwise, we can wait till I have a bit more time.

Kludex avatar Mar 04 '25 08:03 Kludex