opentelemetry-python-contrib icon indicating copy to clipboard operation
opentelemetry-python-contrib copied to clipboard

feat: support batch (getmany) in aiokafka instrumentation

Open dimastbk opened this issue 9 months ago • 0 comments
trafficstars

Description

This PR adds support for reading batches in aiokafka (method getmany). And some fixes:

  • remove dumping to json in SERVER_ADDRESS
  • improve typing
  • sync span attributes with spec
  • fix warnings about unclosed resources in tests
  • fix error if headers are immutable

partial fix #3087

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ ] Test A

Does This PR Require a Core Repo Change?

  • [ ] Yes. - Link to PR:
  • [x] No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • [x] Followed the style guidelines of this project
  • [x] Changelogs have been updated
  • [x] Unit tests have been added
  • [ ] Documentation has been updated

dimastbk avatar Feb 11 '25 13:02 dimastbk