opentelemetry-python-contrib
opentelemetry-python-contrib copied to clipboard
Add missing requirements and test processor baggage in CI
trafficstars
Fixes #2716
Is the package missing a dependency in pyproject to the sdk?
@codeboten PTAL cc @MikeGoldsmith
@ocelotl Could you please add this while at it? It is importing the SpanProcessor from sdk
diff --git a/processor/opentelemetry-processor-baggage/pyproject.toml b/processor/opentelemetry-processor-baggage/pyproject.toml
index 3fa80e15..29fc2e86 100644
--- a/processor/opentelemetry-processor-baggage/pyproject.toml
+++ b/processor/opentelemetry-processor-baggage/pyproject.toml
@@ -26,6 +26,7 @@ classifiers = [
]
dependencies = [
"opentelemetry-api ~= 1.5",
+ "opentelemetry-sdk ~= 1.5",
"wrapt >= 1.0.0, < 2.0.0",
]
BTW cannot test this package locally:
tox -e py310-test-processor-baggage
...
py310-test-processor-baggage: failed with pytest is not allowed, use allowlist_externals to allow it
@ocelotl Could you please add this while at it? It is importing the SpanProcessor from sdk
diff --git a/processor/opentelemetry-processor-baggage/pyproject.toml b/processor/opentelemetry-processor-baggage/pyproject.toml index 3fa80e15..29fc2e86 100644 --- a/processor/opentelemetry-processor-baggage/pyproject.toml +++ b/processor/opentelemetry-processor-baggage/pyproject.toml @@ -26,6 +26,7 @@ classifiers = [ ] dependencies = [ "opentelemetry-api ~= 1.5", + "opentelemetry-sdk ~= 1.5", "wrapt >= 1.0.0, < 2.0.0", ]
Right, added it.
BTW cannot test this package locally:
tox -e py310-test-processor-baggage ... py310-test-processor-baggage: failed with pytest is not allowed, use allowlist_externals to allow it
Weird, should be working pytest is already in test-requiremnets.txt (I also just tried locally and can run the tests).