opentelemetry-python-contrib icon indicating copy to clipboard operation
opentelemetry-python-contrib copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Add NoOpTracerProvider test cases for sqllite3 instrumentation

Open Sunilwali679 opened this issue 1 year ago • 5 comments
trafficstars

Description

Adds NoOpTracerProvider test cases for sqllite3 instrumentation.

Fixes #964

How Has This Been Tested?

tox -e test-instrumentation-sqlite3

instrumentation/opentelemetry-instrumentation-sqlite3/tests/test_sqlite3.py::TestSQLite3::test_callproc PASSED [ 25%] instrumentation/opentelemetry-instrumentation-sqlite3/tests/test_sqlite3.py::TestSQLite3::test_execute PASSED [ 50%] instrumentation/opentelemetry-instrumentation-sqlite3/tests/test_sqlite3.py::TestSQLite3::test_executemany PASSED [ 75%] instrumentation/opentelemetry-instrumentation-sqlite3/tests/test_sqlite3.py::TestSQLite3::test_no_op_tracer_provider PASSED [100%]

Does This PR Require a Core Repo Change?

No.

Sunilwali679 avatar Jul 16 '24 08:07 Sunilwali679

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: Sunilwali679 (260ee1d51caad8a5018157f7e8c8ac22dd0a5efa, c78e4a3b153f21daaf9e338cf8aaa2455a5a5385, 8a37f52bf5c9368bc8f5b86dc6bf97d52625908e)

linux-foundation-easycla[bot] avatar Jul 16 '24 08:07 linux-foundation-easycla[bot]

@Sunilwali679 you have to sign the CLA in order to contribute to this project, thanks

xrmx avatar Jul 17 '24 07:07 xrmx

@xrmx could you please review the PR ? I have rebased and updated CLA

Sunilwali679 avatar Jul 24 '24 11:07 Sunilwali679

CI is failing. Could you please double-check it?

Is it me or test asserts have been removed?

xrmx avatar Aug 01 '24 12:08 xrmx

CI is failing. Could you please double-check it?

Is it me or test asserts have been removed?

Yes. @Sunilwali679 I think here you should double-check the test implementation and assert 0 spans. Marking as a draft to avoid wrong merge.

emdneto avatar Aug 01 '24 12:08 emdneto