opentelemetry-python-contrib icon indicating copy to clipboard operation
opentelemetry-python-contrib copied to clipboard

[Ep2024-sprints][gh-1638] - Bump aio-pika schema version from 1.11.0 to 1.26.0

Open P6rguVyrst opened this issue 1 year ago • 3 comments
trafficstars

Description

Make sure aio-pika instrumentation follows semantic conventions.

Fixes https://github.com/open-telemetry/opentelemetry-python-contrib/issues/1638

Breaking Attribute Changes:

  • messaging.destination to messaging.destination.name, messaging.rabbitmq.destination.routing_key
  • messaging.conversation_id to messaging.message.conversation_id
  • messaging.temp_destination to messaging.destination.temporary

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x] tox -f py312-aio-pika -- -ra
===================================================================== 9 passed, 7 skipped, 1 warning in 1.45s =====================================================================
  py312-test-instrumentation-aio-pika-0: OK (44.09=setup[0.20]+cmd[9.33,11.51,15.68,6.36,1.01] seconds)
  py312-test-instrumentation-aio-pika-1: OK (40.34=setup[0.05]+cmd[10.33,12.96,9.89,6.28,0.83] seconds)
  py312-test-instrumentation-aio-pika-2: OK (41.36=setup[0.07]+cmd[12.15,10.66,10.60,7.05,0.83] seconds)
  py312-test-instrumentation-aio-pika-3: OK (50.91=setup[0.05]+cmd[13.01,11.57,10.96,12.74,2.59] seconds)
  congratulations :) (176.91 seconds)

Does This PR Require a Core Repo Change?

  • [ ] Yes. - Link to PR:
  • [x] No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • [x] Followed the style guidelines of this project
  • [x] Changelogs have been updated
  • [ ] Unit tests have been added
  • [ ] Documentation has been updated

P6rguVyrst avatar Jul 13 '24 13:07 P6rguVyrst