opentelemetry-python-contrib icon indicating copy to clipboard operation
opentelemetry-python-contrib copied to clipboard

added conditional calling of `unary_unary` etc functions in `_InterceptorChannel`

Open VamsiKrishna1211 opened this issue 1 year ago • 5 comments
trafficstars

Fixes #2483

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Installing the grpc contrib package along with grpc>=1.63.0 version.

Does This PR Require a Core Repo Change?

  • [ ] Yes. - Link to PR:
  • [x] No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • [x] Followed the style guidelines of this project
  • [ ] Changelogs have been updated
  • [ ] Unit tests have been added
  • [ ] Documentation has been updated

VamsiKrishna1211 avatar Apr 30 '24 19:04 VamsiKrishna1211

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: VamsiKrishna1211 / name: Vamsi Kocherla (eef229e2546f1828b60ef729c4d2492da1c0d398, 9200bffa536dec11e885dce6ec0540f3a4c58eaf, a0ad24ceeec9b1c9b83045121bc0510d19e364ff, 0f999de0c01142095c53e9b7825d3f7be493ee01, f4faa836bcd04ab91da6e257eb9e3f60538e19d7, 7afc68a174e912d806f01a37b0f7cdb2cc682939, 98f34b05dca9e1d8c186d0b9706f103da8374bfd, fb9bcc124204443f21d2087cc56620492f861a8c, cb250e80c42eeecbe40bb95201f066e13f8d413c, 629c5fce2b79f15d8c3965c96b0b25bbdeba95c9, 2c2c25d68b5803ee7daa886aa173e91965cfae43, b310b4cbbe458df80a094c8814c90b57c33c23c4)
  • :white_check_mark: login: lzchen / name: Leighton Chen (023edcd5cc5af84e4fa5e54c887d008b3308941a)
  • :white_check_mark: login: xrmx / name: Riccardo Magliocchetti (03c6392ac5f35697460a305310e6a6a8ecc436da)

@VamsiKrishna1211 care to add a test with updated test requirements so we can actually test it in CI?

xrmx avatar May 02 '24 13:05 xrmx

@xrmx Yes sure. This is my first contribution to otel-contrib repository. So please let me know if I have to make any other changes in the PR. :)

VamsiKrishna1211 avatar May 02 '24 17:05 VamsiKrishna1211

@xrmx Yes sure. This is my first contribution to otel-contrib repository. So please let me know if I have to make any other changes in the PR. :)

Cool! tests and an entry in CHANGELOG should be enough

xrmx avatar May 02 '24 18:05 xrmx

Cool! tests and an entry in CHANGELOG should be enough

@xrmx The changes in the PR pertain to instrumentation-grpc only, and I need to test with multiple versions of grpcio package. More specifically grpcio>=1.63.0 and grpcio<1.63.0. Because there is a breaking change introduced in the methods of Channel class in latest release of grpcio==1.63.0.

Is there any standard way already you guys follow to test these kind of scenarios?

VamsiKrishna1211 avatar May 02 '24 19:05 VamsiKrishna1211

@VamsiKrishna1211 you can take a look at opentelemetry-instrumentation-httpx both in tox.ini (grep for httpx) and in the instrumentation package dir

xrmx avatar May 03 '24 07:05 xrmx

@xrmx Thanks for correcting the _registered_method argument, I think missed it by accident.

VamsiKrishna1211 avatar May 17 '24 05:05 VamsiKrishna1211

@VamsiKrishna1211 could you please add a CHANGELOG entry? And fix lint and CLA please

xrmx avatar May 20 '24 12:05 xrmx

@VamsiKrishna1211 could you please add a CHANGELOG entry? And fix lint and CLA please

@xrmx Apologies for the delayed changes, was caught up with my full-time work for a while. Added the changes to CHANGELOG and fixed the CLA, please check and let me know for any other issues.

VamsiKrishna1211 avatar Jun 18 '24 15:06 VamsiKrishna1211

@xrmx Updated the repo with the changes.

VamsiKrishna1211 avatar Jun 18 '24 15:06 VamsiKrishna1211

@aabmass Can you look into the MR? We're currently trying to update our packages to their latest version (Official nvidia-triton-client package mainly) while also using open-telemetry. But is causing issues because of the issue attached to this MR.

VamsiKrishna1211 avatar Jul 29 '24 12:07 VamsiKrishna1211