opentelemetry-python-contrib icon indicating copy to clipboard operation
opentelemetry-python-contrib copied to clipboard

Reinstate tox -e lint

Open xrmx opened this issue 1 year ago • 1 comments

Description

Reintroduce the lint environment after 5116305f77bcd4c8ab18ef302a4351bb5b724c1e to just run the cheap linting tools so that developers can rely on it

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x] tox -e lint

Does This PR Require a Core Repo Change?

  • [ ] Yes. - Link to PR:
  • [x] No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • [ ] Followed the style guidelines of this project
  • [ ] Changelogs have been updated
  • [ ] Unit tests have been added
  • [ ] Documentation has been updated

xrmx avatar Apr 30 '24 16:04 xrmx

Do we really need this? :thinking: We already have linting for every package, is there a place where we are not providing linting right now?

ocelotl avatar May 02 '24 21:05 ocelotl

Do we really need this? 🤔 We already have linting for every package, is there a place where we are not providing linting right now?

The only reason for this in the CONTRIBUTING hunk, we have to make it simple for people to run these tools otherwise they don't.

xrmx avatar May 03 '24 07:05 xrmx