opentelemetry-python-contrib icon indicating copy to clipboard operation
opentelemetry-python-contrib copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Repeated headers list for ASGI frameworks

Open samuelcolvin opened this issue 1 year ago • 2 comments
trafficstars

Description

Use a list, rather than a comma separate string to represent repeated HTTP request and response headers.

fixes #2360 fixes #2358 followup to #2266

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

tests updated

Does This PR Require a Core Repo Change?

  • [ ] Yes. - Link to PR:
  • [x] No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • [x] Followed the style guidelines of this project
  • [x] Changelogs have been updated
  • [x] Unit tests have been added/updated
  • [x] Documentation has been updated

samuelcolvin avatar Mar 20 '24 16:03 samuelcolvin

@samuelcolvin please rebase

xrmx avatar Mar 22 '24 11:03 xrmx

Okay, think this is good.

I got so confused about all the wsgi based web frameworks, some use enviroment variables to pass request headers (and repsonse headers? 🤷 ) some don't, sometimes. It's not helped by the fact that lots of the tests combine "multiple" headers into one key-value pair with comma separation.

I therefore reverted all the changes in wsgi and flask, and concentrated on getting the ASGI based frameworks right.

samuelcolvin avatar May 01 '24 12:05 samuelcolvin

@samuelcolvin

Hey gentle ping, are you still working on this?

lzchen avatar Jun 05 '24 18:06 lzchen

Sorry, I've been busy and dropped the ball, I'll try to fix soon.

Samuel

On Wed, 5 Jun 2024, 19:20 Leighton Chen, @.***> wrote:

@samuelcolvin https://github.com/samuelcolvin

Hey gentle ping, are you still working on this?

— Reply to this email directly, view it on GitHub https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2361#issuecomment-2150681353, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA62GGJJ2B6XQPELBV7F56LZF5JGLAVCNFSM6AAAAABE7Y4VZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJQGY4DCMZVGM . You are receiving this because you were mentioned.Message ID: @.*** com>

samuelcolvin avatar Jun 05 '24 18:06 samuelcolvin