opentelemetry-python-contrib icon indicating copy to clipboard operation
opentelemetry-python-contrib copied to clipboard
verified publisher icon open-telemetry

feat(flask,wsgi): Add exemplars to metrics

Open AlexisBRENON opened this issue 2 years ago • 3 comments

Description

Close the request span after publishing the metrics to allow exemplar generation.

Fixes #2158

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

TBD

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • [x] Followed the style guidelines of this project
  • [x] Changelogs have been updated
  • [ ] Unit tests have been added
  • [ ] Documentation has been updated

AlexisBRENON avatar Feb 09 '24 11:02 AlexisBRENON

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: AlexisBRENON / name: Alexis BRENON (fe3e35afc304c3c8fafb391c644b4a125e8a9b05)

linux-foundation-easycla[bot] avatar Feb 09 '24 11:02 linux-foundation-easycla[bot]

@thanks for the PR, could you please rebase on latest main and fix conflicts please?

xrmx avatar Apr 09 '24 10:04 xrmx

Should I update it to make exemplars available as soon as it is in the SDK ? Else, we should probably close the PR.

AlexisBRENON avatar Apr 10 '24 14:04 AlexisBRENON

@AlexisBRENON Please reopen once exemplars are available in the SDK.

ocelotl avatar Jul 01 '24 20:07 ocelotl