opentelemetry-python-contrib icon indicating copy to clipboard operation
opentelemetry-python-contrib copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

feat: Respect "suppress_instrumentation" in redis instrumentor

Open martimors opened this issue 2 years ago • 4 comments
trafficstars

Description

Fixes https://github.com/open-telemetry/opentelemetry-python-contrib/issues/2057

I'll wait until I get some feedback to update the changelog and the docs if need be.

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x] Manual test
  • [x] Unit test

Does This PR Require a Core Repo Change?

  • [ ] Yes. - Link to PR:
  • [x] No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • [x] Followed the style guidelines of this project
  • [ ] Changelogs have been updated
  • [x] Unit tests have been added
  • [ ] Documentation has been updated

martimors avatar Nov 15 '23 11:11 martimors

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: martimors / name: Martin Morset (f60a669b7654606536f259ebdeb8c3234d0ff061, 201470f4df16ec8f4d9f1ac297de46115aa9b711, aac4f7abc9a15e2f385f958951c98313d36a520c, 1744eba3c513ed5542411150bd8819015f3b3901, a6260a226fdcb3f7cd6897bc7ab1cb14b718b634, eed93aa453b0df3989355189d6ec3ce88835064d, 40751736692433abafafb5531faa97f09f3fde17, 20b551e37b258d11bb3c0451b4ea5afe664fa084, 1ff4c0be005ad95bdba3375eb8ca1c02295b22c1, 8d8eb6f842fe2e0a2ff472fdc8f93f43f555c1a5)
  • :white_check_mark: login: xrmx / name: Riccardo Magliocchetti (2677a7e74be9e9f496715604ab3cfdd96ca1254b)
  • :white_check_mark: login: ocelotl / name: Diego Hurtado (88f1b9a9cab27a05d5f74ec7fef8d8eada8ce0d0)

linux-foundation-easycla[bot] avatar Nov 15 '23 11:11 linux-foundation-easycla[bot]

Sorry for the commit spam - I'm just reviewing myself as best I can while not being able to run the tests locally. Do you have some guide how to get that up and running, preferably in the IDE and not tox on the cli? That would make this development experience a lot better for me.

martimors avatar Feb 29 '24 12:02 martimors

@federicobond are we good to go here?

martimors avatar Apr 22 '24 08:04 martimors

@martimors please take a look at the failures. The only way we can run tests is by using tox, which actually will create a virtual environment with all the testing dependencies installed and the pytest will run the tests.

ocelotl avatar Apr 22 '24 22:04 ocelotl