opentelemetry-python-contrib icon indicating copy to clipboard operation
opentelemetry-python-contrib copied to clipboard

add middleware_position feature in django

Open TheAnshul756 opened this issue 2 years ago • 1 comments
trafficstars

Description

Feature to add middleware at specific location. Added keyword argument middleware_position which one can set to the number of middleware they want to add before otel middleware to start instrumentation.

Fixes #1781

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [x] This change requires a documentation update

How Has This Been Tested?

  • [x] tox -e lint
  • [x] tox -e test-instrumentation-django1
  • [x] tox -e test-instrumentation-django2
  • [x] tox -e test-instrumentation-django3

Does This PR Require a Core Repo Change?

  • [x] No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • [x] Followed the style guidelines of this project
  • [x] Changelogs have been updated
  • [x] Unit tests have been added
  • [ ] Documentation has been updated

TheAnshul756 avatar Aug 06 '23 13:08 TheAnshul756

@TheAnshul756 This PR has enough approvals, seems we only need a few fixes in order to merge it. :+1:

ocelotl avatar Aug 30 '23 14:08 ocelotl