opentelemetry-python-contrib
opentelemetry-python-contrib copied to clipboard
open-telemetry
Exclude gc_count from system-metrics instrumentation
Co-authored-by: SuryanarayanaPeri [email protected]
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #1033
Type of change
Please delete options that are not relevant.
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
- [ ] Test A
Does This PR Require a Core Repo Change?
- [ ] Yes. - Link to PR:
- [ ] No.
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
- [x] Followed the style guidelines of this project
- [x] Changelogs have been updated
- [x] Unit tests have been added
- [ ] Documentation has been updated
Please add a more descriptive name to this PR and also fix lint.
Lint issue is fixed
We need tests for these changes.
@ocelotl : Added the test cases
@ocelotl : Some of the checks are failing. Can you please help if missing anything, need some guidance?? As per the understanding we have added the code and test cases accordingly.
@ocelotl - The work in this issue is to make the instrumentation either produce all the same metrics or exclude the instruments that don't have equivalents. Ideally at the end of this issue, the tests for this instrumentation library will be enabled in tox for pypy3.
For this we have excluded the instruments that don't have equivalents for the gc_count on pypy3. The test for the system metrics instrumentation is enabled in tox. Request you please review and merge the PR.
We will open a new feature request - to make the instrumentation to provide the gc_count metrics for pypy3.
We need tests for these changes.
@ocelotl :Added the test cases to support the pypy3 for system metrics instrumentation.
Ok, almost ready to approve and merge, just take a look at the comment above and implement the requested changes :v:
@ocelotl : Please don't approve the PR, just hold for one or two days, will let you KNOW and then you can merge the PR
@ocelotl : Please don't approve the PR, just hold for one or two days, will let you KNOW and then you can merge the PR, reverting the logger changes