opentelemetry-proto icon indicating copy to clipboard operation
opentelemetry-proto copied to clipboard

opentelemetry-proto tar archive contains spurious files

Open marcalff opened this issue 1 year ago • 6 comments

The file opentelemetry-proto-1.4.0.tar.gz contains the following:

  • buf.yaml
  • package.json
  • package-lock.json

which are also present in git in the opentelemetry-proto repository.

These do not look like items that should be maintained in git, and should be removed.

marcalff avatar Nov 28 '24 10:11 marcalff

The reason this happens is that the current release process does not have a build step. It simply ends up packing the entire repo's content into the release file.

tigrannajaryan avatar Nov 28 '24 16:11 tigrannajaryan

@tigrannajaryan is this open ? can I contribute ?

RajaVarmaGVSSR avatar Sep 30 '25 10:09 RajaVarmaGVSSR

@RajaVarmaGVSSR before creating a PR please post here what the plan is, what you would like to do. I would like it to be discussed before implementing. The plan needs to be simple, we don't want complicated release/build processes that add work for maintainers.

tigrannajaryan avatar Sep 30 '25 14:09 tigrannajaryan

@tigrannajaryan I would be just adding export-ignore for buf.yaml in .gitattributes, the existing git archive release process will respect .gitattributes and exclude the buf.yaml

RajaVarmaGVSSR avatar Oct 01 '25 12:10 RajaVarmaGVSSR

@tigrannajaryan I would be just adding export-ignore for buf.yaml in .gitattributes, the existing git archive release process will respect .gitattributes and exclude the buf.yaml

@RajaVarmaGVSSR I think this makes sense, I didn't know this was an option.

@open-telemetry/spec-sponsors any thoughts?

tigrannajaryan avatar Oct 01 '25 12:10 tigrannajaryan

The plan seems reasonable to me 👍🏻

codeboten avatar Oct 01 '25 16:10 codeboten