opentelemetry-proto icon indicating copy to clipboard operation
opentelemetry-proto copied to clipboard

Probably unintentional proto field ID gaps in the Sample message in pprofextended

Open aalexand opened this issue 9 months ago • 0 comments

Reordering things:

message Sample {
  repeated uint64 location_index = 1;
  repeated int64 value = 2;
  repeated Label label = 3;

  // fields 4, 5, 6 are missing.

  uint64 locations_start_index = 7;
  uint64 locations_length = 8;
  uint32 stacktrace_id_index = 9;
  repeated uint64 attributes = 10;

  // field 11 is missing

  uint64 link = 12;
  repeated uint64 timestamps_unix_nano = 13;
}

This seems unintentional.

@petethepig FYI

aalexand avatar May 18 '24 01:05 aalexand