opentelemetry-proto icon indicating copy to clipboard operation
opentelemetry-proto copied to clipboard

In pprofextended proto, consider moving Location.type_index to Mapping

Open aalexand opened this issue 9 months ago • 4 comments

We define it as

  // Type of frame (e.g. kernel, native, python, hotspot, php). Index into string table.
  uint32 type_index = 6;

I can't easily think of a case where the type of locations would be different for the given mapping. This could probably be moved to the mapping message which would also save some profile size since locations tend to come in much larger quantities compared to mappings.

Related: Could this type be an attribute? Both mapping and location have attributes attached.

aalexand avatar May 18 '24 00:05 aalexand