opentelemetry-proto icon indicating copy to clipboard operation
opentelemetry-proto copied to clipboard

Add TraceState to the LogRecord

Open bogdandrutu opened this issue 1 year ago • 4 comments

bogdandrutu avatar Jan 09 '24 19:01 bogdandrutu

I am struggling to understand what is the meaning and purpose of the tracestate in a LogRecord. Can someone explain? What do the receivers of such LogRecord supposed to do with this data?

tigrannajaryan avatar Jan 11 '24 23:01 tigrannajaryan

I am struggling to understand what is the meaning and purpose of the tracestate in a LogRecord. Can someone explain? What do the receivers of such LogRecord supposed to do with this data?

These are same reasons as why we propagate probability sampler here; TL;DR is that if you derive any metrics from these logs/events you can have a "weight" associated with that.

bogdandrutu avatar Jan 12 '24 18:01 bogdandrutu

Please add a description to this PR and refer to issues where this was discussed. I believe we had decided not to do this. Sampling SIG has discussed creating semantic conventions for encoding information we might usefully extract from tracestate to apply to log records, e.g., sampling.threshold, sampling.priority, and sampling.randomness.

jmacd avatar Jan 26 '24 14:01 jmacd

Please add a description to this PR and refer to issues where this was discussed. I believe we had decided not to do this.

I don't have an issue, but if you have any prior discussion would be good to link as reference.

Sampling SIG has discussed creating semantic conventions for encoding information we might usefully extract from tracestate to apply to log records, e.g., sampling.threshold, sampling.priority, and sampling.randomness.

Would this scale for everything we like to put in tracestate (since I believe we may add more things into the tracestate)? What about other's tracestate (e.g. snwoflake's entry)?

bogdandrutu avatar Jan 30 '24 14:01 bogdandrutu