opentelemetry-php icon indicating copy to clipboard operation
opentelemetry-php copied to clipboard

Handle partial success responses from OTLP export services

Open jmacd opened this issue 3 years ago • 3 comments

Problem Statement

Following the specification change to add partial success responses, each OTel SDK is encouraged to handle the resulting error message string in an appropriate way, considering existing norms. This requires OTLP v0.19.

Proposed Solution

For each of the Export*ServiceRequest methods used by OTLP Trace and Metrics exporters, construct an error and call the appropriate handler with the error message string and the number of spans/points(/logs) dropped. Future OTel specifications may call for optional treatment of the number of dropped items, but presently that is just additional information to include in the handled error.

jmacd avatar Aug 19 '22 22:08 jmacd

This will be partly implemented by #806. We'll implement for http+protobuf after https://github.com/open-telemetry/opentelemetry-collector/issues/5816 since we currently have no collector response to work with from that protocol.

brettmc avatar Aug 26 '22 01:08 brettmc

Hi @brettmc should we create a follow up issue to track the implementation for this for http+protobuf?

joaopgrassi avatar Sep 27 '22 07:09 joaopgrassi

Let's please leave this open as long as these responses aren't handled in http/proto and http/json.

jmacd avatar Sep 27 '22 18:09 jmacd

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 29 '22 06:10 stale[bot]