opentelemetry-php icon indicating copy to clipboard operation
opentelemetry-php copied to clipboard

[opentelemetry-php-contrib] AWS: Fix examples

Open tidal opened this issue 3 years ago • 4 comments

The AWS examples are broken at the moment

tidal avatar Dec 20 '21 19:12 tidal

I could take care of that

mtk3d avatar Mar 13 '22 21:03 mtk3d

PR in progress: https://github.com/open-telemetry/opentelemetry-php-contrib/pull/52

mtk3d avatar Mar 14 '22 23:03 mtk3d

PR merged. Happy to close this if you believe it's completed.

bobstrecansky avatar Mar 16 '22 15:03 bobstrecansky

Thanks for merge. There are two apps in the examples, first one is fixed by this PR and I will fix the second one until the next week, then I think this issue will be completed. I think there is still a problem with the first example app, where the calls to AWS services are not showing in the X-Ray dashboard. I tried to find how this should work, and if those calls should be presented in X-Ray traces, but didn't find any satisfactory information. I believe that it was work the same way previously, so I think it should be a separate issue.

mtk3d avatar Mar 16 '22 22:03 mtk3d

Closing due to inactivity, please re-open or create a new issue if this is still relevant.

brettmc avatar Nov 28 '22 00:11 brettmc