opentelemetry-php icon indicating copy to clipboard operation
opentelemetry-php copied to clipboard

[opentelemetry-php-contrib] opentelemetry-auto-doctrine should support php 8.0 and 8.1

Open 4o3F opened this issue 7 months ago • 1 comments

Is your feature request related to a problem? Current open-telemetry/opentelemetry-auto-doctrine is designed based on the PDO instrument, while PDO need PHP8.2 and up, Doctrine with custom driver can work since PHP8.0, so the requirement should be dropped to support more versions.

Describe the solution you'd like DominicDetta has confirmed in his PR comment that PHP 8.0 can work, so we should change the version requirement back.

4o3F avatar May 19 '25 11:05 4o3F

That's true, it should work with 8.1 since it's not an extension. Our support policy dropped 8.0 support when official support ended. Since I have a PR open against doctrine already, I added 8.1 support in https://github.com/open-telemetry/opentelemetry-php-contrib/pull/374/commits/7c3a020e60c7db88c00382361cd3652c653802fc

brettmc avatar May 21 '25 12:05 brettmc

Fixed by https://github.com/open-telemetry/opentelemetry-php-contrib/pull/374

brettmc avatar Jun 27 '25 05:06 brettmc