Remove event logger
Event Logger has been removed from spec, in favour of Logger.EmitEvent. We have deprecated EventLogger in main, this removes it from 2.x and adds EmitEvent as its replacement.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 68.50%. Comparing base (
176b10a) to head (7bd811e). Report is 2 commits behind head on 2.x.
Additional details and impacted files
@@ Coverage Diff @@
## 2.x #1480 +/- ##
============================================
+ Coverage 68.44% 68.50% +0.05%
+ Complexity 2885 2866 -19
============================================
Files 428 422 -6
Lines 8775 8708 -67
============================================
- Hits 6006 5965 -41
+ Misses 2769 2743 -26
| Flag | Coverage Δ | |
|---|---|---|
| 8.2 | 68.39% <100.00%> (?) |
|
| 8.3 | 68.32% <100.00%> (?) |
|
| 8.4 | 68.36% <100.00%> (?) |
|
| 8.5 | 68.36% <100.00%> (-0.09%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files with missing lines | Coverage Δ | |
|---|---|---|
| src/API/Globals.php | 100.00% <100.00%> (ø) |
|
| src/API/Instrumentation/CachedInstrumentation.php | 100.00% <ø> (ø) |
|
| src/API/Instrumentation/Configurator.php | 100.00% <ø> (ø) |
|
| src/API/Instrumentation/ContextKeys.php | 100.00% <ø> (ø) |
|
| .../Config/SDK/ComponentProvider/OpenTelemetrySdk.php | 0.00% <ø> (ø) |
|
| ...rovider/Propagator/TextMapPropagatorCloudTrace.php | 0.00% <ø> (ø) |
|
| src/Config/SDK/_register.php | 0.00% <ø> (ø) |
|
| src/Contrib/Otlp/LogsConverter.php | 93.97% <100.00%> (+1.47%) |
:arrow_up: |
| src/SDK/Logs/Exporter/ConsoleExporter.php | 100.00% <100.00%> (ø) |
|
| src/SDK/Sdk.php | 100.00% <ø> (ø) |
|
| ... and 2 more |
... and 13 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 176b10a...7bd811e. Read the comment docs.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Worth mentioning and discussion, is that in this PR I've removed some methods etc related to event logger. The spec really wants us to not ever make breaking changes to the API. However:
It should be documented that the newly added methods are in Development and are subject to breaking changes.
The event logger was development stability, just not documented as such by us. I think we're allowed to remove non-stable features in a breaking way...