opentelemetry-php icon indicating copy to clipboard operation
opentelemetry-php copied to clipboard

Update `TraceIdRatioBasedSampler` to calculate sampling threshold according to OTEP 235

Open Nevay opened this issue 1 year ago • 1 comments

Computes the sampling threshold as defined in https://github.com/open-telemetry/opentelemetry-specification/pull/4166.

Nevay avatar Sep 28 '24 22:09 Nevay

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.85%. Comparing base (20bf3cf) to head (96bebeb). Report is 73 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1391      +/-   ##
============================================
- Coverage     73.56%   68.85%   -4.72%     
- Complexity     2672     3181     +509     
============================================
  Files           386      415      +29     
  Lines          7650     9285    +1635     
============================================
+ Hits           5628     6393     +765     
- Misses         2022     2892     +870     
Flag Coverage Δ
8.1 70.51% <100.00%> (?)
8.2 70.73% <100.00%> (?)
8.3 70.73% <100.00%> (?)
8.4 68.82% <100.00%> (-4.75%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/SDK/Trace/Sampler/TraceIdRatioBasedSampler.php 100.00% <100.00%> (ø)

... and 274 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 20bf3cf...96bebeb. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Sep 28 '24 22:09 codecov[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 26 '25 05:04 stale[bot]