opentelemetry-php-contrib
opentelemetry-php-contrib copied to clipboard
fix Pre Hook Exception in case _controller is not stringable
closes https://github.com/open-telemetry/opentelemetry-php/issues/1569
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: trigrab / name: Trigrab (a8c7f8e5c9da9b6070142a7dc2f40cfe2059e6ce, 27a36e24409e52a9e8a65dd631a6a1839aa6cb71)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 83.46%. Comparing base (
e6272aa) to head (a8c7f8e). Report is 7 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #366 +/- ##
=========================================
Coverage 83.45% 83.46%
- Complexity 1957 1958 +1
=========================================
Files 143 143
Lines 8190 8193 +3
=========================================
+ Hits 6835 6838 +3
Misses 1355 1355
Flags with carried forward coverage won't be shown. Click here to find out more.
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...rumentation/Symfony/src/SymfonyInstrumentation.php | 80.18% <100.00%> (+0.55%) |
:arrow_up: |
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update e6272aa...a8c7f8e. Read the comment docs.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.