Add imagePullSecrets as field in Collector spec

[m1o1]

Signed-off-by: Andrew DiNunzio <adinunzio84@gmail.com>

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: m1o1 (0a865f523231cad25ff8f1898b01285efb684105)

[m1o1]

Some things need to be cleaned up, just need to read through the contributing docs to see what I missed.

[m1o1]

Need to figure out how to properly set up gpg for signing, so marked as a draft for now.

[pavolloffay]

Try squshing to commits and use -s flag when committing (git commit -s).

[alupuleasa]

Do we have any updates on this? yuriolisa can we merge this?

[yuriolisa]

Do we have any updates on this? yuriolisa can we merge this?

@alupuleasa, before we proceed with the review, @m1o1 should perform the following steps:

• Rebase the PR due to the merge conflicts and switch the draft to PR.
• Sign the PR as expected.
• Fix the required changes.

[m1o1]

/easycla

[alupuleasa]

Can we proceed with the review now?

[m1o1]

/retest

[m1o1]

apparently I'll need to fix some unit tests (could have sworn they were passing!) Will fix ~today~ today

[m1o1]

Running locally, the unit tests and e2e tests are passing, but running make test results in a diff showing up for bundle/manifests/opentelemetry-operator.clusterserviceversion.yaml and failing for that reason.

The diff is just this:

               containers:
+              - args:
+                - --secure-listen-address=0.0.0.0:8443
+                - --upstream=http://127.0.0.1:8080/
+                - --logtostderr=true
+                - --v=0
+                image: gcr.io/kubebuilder/kube-rbac-proxy:v0.11.0
+                name: kube-rbac-proxy
+                ports:
+                - containerPort: 8443
+                  name: https
+                  protocol: TCP
+                resources:
+                  limits:
+                    cpu: 500m
+                    memory: 128Mi
+                  requests:
+                    cpu: 5m
+                    memory: 64Mi
               - args:
                 - --metrics-addr=127.0.0.1:8080
                 - --enable-leader-election
@@ -311,24 +329,6 @@ spec:
                 - mountPath: /tmp/k8s-webhook-server/serving-certs
                   name: cert
                   readOnly: true
-              - args:
-                - --secure-listen-address=0.0.0.0:8443
-                - --upstream=http://127.0.0.1:8080/
-                - --logtostderr=true
-                - --v=0
-                image: gcr.io/kubebuilder/kube-rbac-proxy:v0.11.0
-                name: kube-rbac-proxy
-                ports:
-                - containerPort: 8443
-                  name: https
-                  protocol: TCP
-                resources:
-                  limits:
-                    cpu: 500m
-                    memory: 128Mi
-                  requests:
-                    cpu: 5m
-                    memory: 64Mi
               serviceAccountName: opentelemetry-operator-controller-manager
               terminationGracePeriodSeconds: 10
               volumes:

So it's not really different, just out of order for some reason. Otherwise, I'm not sure why the tests are failing.

[pavolloffay]

Please also add pull secret to the statfulset.

[m1o1]

Please also add pull secret to the statfulset.

Done

[m1o1]

I'm not sure why the security check is failing. Don't see any logs. I just pushed a change to fix the field alignment linting issue. The linter report when I run make lint locally shows a bunch of results not related to my changes, and make vet succeeds for me locally.

[m1o1]

Pulled main into my branch which I think fixes the failing e2e test, please /retest

Locally, ensure-generate-is-noop is still failing in make test, with the same diff as above. Any hints to resolve that? Thanks

[CoderPoet]

Does the java image in instrumentation also need to be supported?

[CoderPoet]

Is the image pull secret of sidecar missing?

[yuriolisa]

@protopapa, would you like to work on that issue?

[protopapa]

@yuriolisa, yes I would like to.

[pavolloffay]

Closing as outdatted PR. The CR has a config option to set a service account that can set the image pull secret