DaemonSet deloyment with private container registry unstable (imagePullSecrets not configurable)

[marcules]

Hi,

when I configure the OpenTelemetryCollector to run as daemonset only nodes, that already contain images from our private image registry come up - as the nodes where such images are not present can't access the configured otel-collector image.

This is not an issue in sidecar mode, as the configured deployments already contain an imagePullSecrets configuration, which the sidecar can use. The issue exists in daemonset, statefulset and deployment (simplest) mode when using a private registry.

Can you add a configuration for spec.containers.[*].imagePullPolicy and spec.imagePullSecrets to the deployment, daemonset ad statefulset CRD? That would enable us to have a reliable way of deploying the otel-collector with our own images.

LG Marc

[pavolloffay]

I don't have objections to add imagePullSecret to the collector CR.

@marcules are you interested in submitting a PR?

[jkroepke]

As I know, you can also attach imagePullSecrets to service accounts as alternative to define them on the Deamonset

[m1o1]

I think this would apply to the Deployment (as opposed to DaemonSet) as well. Just tried using a custom collector and couldn't figure out how to add imagePullSecrets. Going to try adding to the service account, but afaik that service account is managed by the controller so changes could be overwritten.

[m1o1]

I opened a PR. I need to make sure I follow the contributing guidelines and clean it up, but if it looks like I'm on the right track, I'll fix it up.

[protopapa]

Hello, I would like to work on this, if possible

[yuriolisa]

As mentioned by @pavolloffay, The CR has a config option to set a service account that can set the image pull secret.