opentelemetry-operator icon indicating copy to clipboard operation
opentelemetry-operator copied to clipboard
verified publisher icon open-telemetry

Determine better strategy for handling map merging for various fields

Open jaronoff97 opened this issue 1 year ago • 4 comments

Right now we have to manually clear maps for only the node selector in the mutate.go, but i'm sure there are other places where we shouldn't blindly merge things together.

Originally posted by @swiatekm-sumo in https://github.com/open-telemetry/opentelemetry-operator/pull/2941#pullrequestreview-2050424029

jaronoff97 avatar May 10 '24 17:05 jaronoff97

In reality, I think the logic here should be very simple. We should clear everything except labels and annotations, and even in their case I'm not completely convinced this is a good idea. It's another question whether this is actually straightforward to do with our current tooling.

swiatekm avatar May 14 '24 10:05 swiatekm

Yeah maybe this is worth doing for everything... if anyone reading this wants to check it out do reach out!

jaronoff97 avatar May 23 '24 16:05 jaronoff97

I would like to work on this.

davidhaja avatar Sep 23 '24 15:09 davidhaja

thanks @davidhaja :D Let me know if you need any assistance :bow:

jaronoff97 avatar Sep 23 '24 15:09 jaronoff97