opentelemetry-operator icon indicating copy to clipboard operation
opentelemetry-operator copied to clipboard

Auto-instrumentation injection for webservers (nginx, apache)

Open svrnm opened this issue 3 years ago • 5 comments

For both nginx and apache there are modules that add otel to the webservers (otel-webserver-module).

Using them, it should be possible to inject otel into containers running one of them like it is done right now for different languages:

  • Provide a docker image that downloads & installs the modules
  • Provide the code for injection (like javaagent.go)

My first question is, if the project would accept such an addition to the auto-instrumentation injection?

Thanks!

cc: @DebajitDas, @ajaynagariya, @mhosabettu

svrnm avatar Aug 09 '22 13:08 svrnm

I don't have objections, however I don't know how the instrumentation installation of the webserver/nginx works. If you could outline an approach that the operator could use it would be helpful.

Provide a docker image that downloads & installs the modules

The operator should ideally use pre-build images to avoid unnecessary long init times.

pavolloffay avatar Aug 09 '22 13:08 pavolloffay

I don't have objections, however I don't know how the instrumentation installation of the webserver/nginx works. If you could outline an approach that the operator could use it would be helpful.

Sure, Will follow up with some details!

Provide a docker image that downloads & installs the modules

The operator should ideally use pre-build images to avoid unnecessary long init times.

Makes sense!

svrnm avatar Aug 10 '22 08:08 svrnm

Apache, by @chrlic: https://github.com/open-telemetry/opentelemetry-operator/pull/1082

svrnm avatar Sep 15 '22 07:09 svrnm

thanks @svrnm, it is great. We will need the commitment to maintain the apache auto-instrumenation in the operator.

The operator supports a wide range of auto-instrumentations, and it is becoming increasingly hard to maintain all these integrations and fix user issues.

pavolloffay avatar Sep 15 '22 08:09 pavolloffay

thanks @svrnm, it is great. We will need the commitment to maintain the apache auto-instrumenation in the operator.

The operator supports a wide range of auto-instrumentations, and it is becoming increasingly hard to maintain all these integrations and fix user issues.

I understand that, similar situation as with many other pieces of the otel projects.

I think that adding auto-instrumentation through the operator is a key feature end users are looking for, so let me see what we can do to help with the maintenance of them (not only apache)

cc: @pavankrish123 , @kelseyma

svrnm avatar Sep 15 '22 08:09 svrnm