opentelemetry-network icon indicating copy to clipboard operation
opentelemetry-network copied to clipboard

support fedora in kernel header install script

Open tsloughter opened this issue 10 months ago • 5 comments

Description: <Describe what has changed.>

Fixes https://github.com/open-telemetry/opentelemetry-network/issues/261 by supporting fedora in the kernel header install script

Link to tracking Issue: <Issue number if applicable>

https://github.com/open-telemetry/opentelemetry-network/issues/261

Testing: <Describe what testing was performed and which tests were added.>

Working on manual testing, currently stuck trying to build opentelemetry-ebpf-build-tools because it "freezes" on Cloning into '/home/tristan/Devel/opentelemetry-ebpf-build-tools/gcp_cpp/google-cloud-cpp'...

I was also going to add to the CI tests but was getting confused hoping around shell scripts. If anyone can help explain what needs to be updated there I'd be happy to add fedora to the distros tested against if its desired.

Documentation: <Describe the documentation added.>

None. It doesn't appear there are any docs about what hosts are supported, so if wanted I can add a list of supported distros to https://github.com/open-telemetry/opentelemetry-network/blob/main/docs/kernel-collector.md, not sure if anywhere else would be appropriate to add that info?

tsloughter avatar Apr 15 '24 10:04 tsloughter

Working on manual testing, currently stuck trying to build opentelemetry-ebpf-build-tools because it "freezes" on Cloning into '/home/tristan/Devel/opentelemetry-ebpf-build-tools/gcp_cpp/google-cloud-cpp'...

Could the problem be related to this issue?

Documentation:

None. It doesn't appear there are any docs about what hosts are supported, so if wanted I can add a list of supported distros to https://github.com/open-telemetry/opentelemetry-network/blob/main/docs/kernel-collector.md, not sure if anywhere else would be appropriate to add that info?

Yes! It's important enough to add to the main project README, IMO. Happy to review a PR!

yonch avatar Apr 15 '24 16:04 yonch

I was also going to add to the CI tests but was getting confused hoping around shell scripts. If anyone can help explain what needs to be updated there I'd be happy to add fedora to the distros tested against if its desired.

@samiura @atoulme any pointers you can share?

yonch avatar Apr 15 '24 16:04 yonch

I took a look at the Github Actions result for this branch, looks like it is indeed similar to the problem in #256

yonch avatar Apr 15 '24 16:04 yonch

Yes! It's important enough to add to the main project README, IMO. Happy to review a PR!

Alright, will do!

tsloughter avatar Apr 15 '24 22:04 tsloughter

Hey there! I faced a similar problem with freezing while building the build-env on fedora. I've had 2 problems when building: The first one may be relevant if you are using docker desktop. I had to swap from the "linux-desktop" (or somesuch, it had "linux" in the name) to just "docker" in the builder settings. Docker desktop defaults to this builder and you have to switch manually in the app and run systemctl start docker. I have no idea why, but it resolved the issue for me.

The second one was that I just ran out of RAM. My system has 32 gigs and I had to mount additional swap memory for it to be able to handle the build (it took about 9 more gigs of swap at most).

Hope this can help you with getting it running @tsloughter !

kubakukis14 avatar Apr 16 '24 14:04 kubakukis14