opentelemetry-lambda
opentelemetry-lambda copied to clipboard
fix: format shell script and set option
Remove extra space and set pipefail option
set -o pipefail This setting prevents errors in a pipeline from being masked. If any command in a pipeline fails, that return code will be used as the return code of the whole pipeline. By default, the pipeline's return code is that of the last command even if it succeeds.
- :x: The commit (a292d256a330d8fc047fd43601d542a01954ab67). This user is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.
I signed the CLA, but I am not sure if I can re-run the CI check
Was there something failing that led you to add this? I may be missing it but I don't see any pipes being used in this script. Does something get translated to a pipeline?
Was there something failing that led you to add this? I may be missing it but I don't see any pipes being used in this script. Does something get translated to a pipeline?
I was browsing the repo and noticed the whitespace, thought I would make a quick PR. Pipefail is generally a best practice for any shell script, thus I don't think YAGNI applies.
Unfortunately quick PRs still require the CLA. Do you want to go through that process or should we close the PR?
I do appreciate the consideration though. For future reference, here's the recommended settings for bash scripts: https://sipb.mit.edu/doc/safe-shell/