opentelemetry-lambda icon indicating copy to clipboard operation
opentelemetry-lambda copied to clipboard

Collector start error is never surfaced

Open rakyll opened this issue 4 years ago • 0 comments

ipp.appDone = make(chan struct{})
	go func() {
		defer close(ipp.appDone)
		appErr := ipp.svc.Run()
		if appErr != nil {
			err = appErr
		}
	}()

The err assignment here can happen after start function returns. This logic won't surface the ipp.svc.Run errors.

rakyll avatar Apr 16 '21 01:04 rakyll