opentelemetry-lambda
opentelemetry-lambda copied to clipboard
make log level configurable, cleanup logging
This tries to address #230 by exposing a new setting OPENTELEMETRY_EXTENSION_LOG_LEVEL
which allows the log level to be configured.
- :x: The commit (c70637d5fd848467ff24ebb71f566917f71e544d, 6e937d6e4b99f3ff9af56b377bfb77abcf6c7050, 7518857f84a05fcf337af44e02e43f6ff5c60b47, 09ee03de11c731f04b3bb1398792faff6479235d). This user is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.
CLA should now be signed, not sure how to kick off a retest
any reason why its not merge yet?
Could @Aneurysm9 or @vasireddy99 take a look and approve?
It will be useful to have the usage of env variable documented as part of the PR.
Adding PR desc: Test results in this comment shows it doesn't provide extension logs when the variable is not set.
Further chore work could be done in next PR's.
You guys still working on this one.It will help if this get merge.
For what is worth, I have tested this branch and it seem to do what it says. Hopefully it will be merged soon, as it's really useful not to be swamped in log messages.
One note would be to document somewhere how to pass the log levels. I had to dig into the zap library source code to know it's "warn" or "WARN" and not "Warning", or "warning"...
See https://github.com/uber-go/zap/blob/ed5598a9e26d75aae01f4846ce31b3fe785c57c7/zapcore/level.go#L180
How can we get more eyes on this so that this can get merged?
This has been superseded via #316.