opentelemetry-lambda icon indicating copy to clipboard operation
opentelemetry-lambda copied to clipboard

make log level configurable, cleanup logging

Open nevins-b opened this issue 2 years ago • 6 comments

This tries to address #230 by exposing a new setting OPENTELEMETRY_EXTENSION_LOG_LEVEL which allows the log level to be configured.

nevins-b avatar Aug 10 '22 14:08 nevins-b

CLA Missing ID CLA Not Signed

  • :x: The commit (c70637d5fd848467ff24ebb71f566917f71e544d, 6e937d6e4b99f3ff9af56b377bfb77abcf6c7050, 7518857f84a05fcf337af44e02e43f6ff5c60b47, 09ee03de11c731f04b3bb1398792faff6479235d). This user is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

CLA should now be signed, not sure how to kick off a retest

nevins-b avatar Aug 10 '22 14:08 nevins-b

any reason why its not merge yet?

klagupl avatar Aug 29 '22 11:08 klagupl

Could @Aneurysm9 or @vasireddy99 take a look and approve?

NathanielRN avatar Aug 30 '22 16:08 NathanielRN

It will be useful to have the usage of env variable documented as part of the PR.

vasireddy99 avatar Aug 31 '22 01:08 vasireddy99

Adding PR desc: Test results in this comment shows it doesn't provide extension logs when the variable is not set. Further chore work could be done in next PR's. Screen Shot 2022-09-14 at 10 29 00 AM

vasireddy99 avatar Sep 14 '22 17:09 vasireddy99

You guys still working on this one.It will help if this get merge.

goyatparmod avatar Oct 26 '22 18:10 goyatparmod

For what is worth, I have tested this branch and it seem to do what it says. Hopefully it will be merged soon, as it's really useful not to be swamped in log messages.

One note would be to document somewhere how to pass the log levels. I had to dig into the zap library source code to know it's "warn" or "WARN" and not "Warning", or "warning"...

See https://github.com/uber-go/zap/blob/ed5598a9e26d75aae01f4846ce31b3fe785c57c7/zapcore/level.go#L180

nerochiaro avatar Nov 09 '22 10:11 nerochiaro

How can we get more eyes on this so that this can get merged?

monken avatar Nov 21 '22 20:11 monken

This has been superseded via #316.

Aneurysm9 avatar Nov 22 '22 17:11 Aneurysm9