opentelemetry-js icon indicating copy to clipboard operation
opentelemetry-js copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Fix #4712

Open alecmev opened this issue 1 month ago • 0 comments

Which problem is this PR solving?

Fix #4712, related to #3713.

TypeScript emits InstrumentationNodeModuleDefinition with | undefined for some reason, making it incompatible with InstrumentationModuleDefinition under exactOptionalPropertyTypes: true.

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

I'm using OpenTelemetry indirectly via Sentry. I applied this patch locally to the latest version of @opentelemetry/instrumentation and it resolved the issue.

Checklist:

  • [x] Followed the style guidelines of this project
  • [ ] Unit tests have been added
  • [ ] Documentation has been updated

alecmev avatar Jun 30 '24 21:06 alecmev