opentelemetry-js icon indicating copy to clipboard operation
opentelemetry-js copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

refactor(instr-fetch): move fetch to use SEMATRR

Open pahiz opened this issue 10 months ago • 4 comments

Which problem is this PR solving?

Updates https://github.com/open-telemetry/opentelemetry-js/issues/4567

Short description of the changes

  • Updates deprecated SemanticAttributes in experimental package instrumentation-fetch

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • [x] npm test

Checklist:

  • [x] Followed the style guidelines of this project
  • [x] Unit tests have been added
  • [x] Documentation has been updated

pahiz avatar Apr 14 '24 14:04 pahiz

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: mmouru (015b1df58825e98301b281804f0699b930c05512, d16fa9e055747735f85161df7dbf6969a030cf1e)
  • :white_check_mark: login: JamieDanielson / name: Jamie Danielson (5da16391222439b5105d4ddac05fec59adfbe75c, 2491bdb375b4559ae7f398416c17cd9075d26e5f, 119cfbf87aa3279f739a679e5b15ae4cf8d0f63a)

linux-foundation-easycla[bot] avatar Apr 14 '24 14:04 linux-foundation-easycla[bot]

Hi @mmouru

thanks for contributing into our effort to update semantic conventions. 🎉

Would you please complete this PR by adding a section in the README file listing the attributes used in this instrumentation?

You can have a look at intrumentation-http README

david-luna avatar Apr 25 '24 07:04 david-luna

Thank you @mmouru for your contribution :)

Would you please add a section in the README file listing the attributes used in this instrumentation? Here is an example (you can omit the 3rd column) https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/opentelemetry-instrumentation-http#semantic-conventions

david-luna avatar May 07 '24 11:05 david-luna

done my bits

pahiz avatar May 07 '24 18:05 pahiz

~Oh. @mmouru I've just realized you haven't signed the CLA. Can you please take care of that so we can move forward with this PR?~ fixed

JamieDanielson avatar Jun 03 '24 20:06 JamieDanielson

Oh. @mmouru I've just realized you haven't signed the CLA. Can you please take care of that so we can move forward with this PR?

~🤔 Looks like you've contributed before; there was a problem for a short time with EasyCLA, try adding a comment that says /easycla and that might fix it.~

EDIT never mind, looks like I was able to fix it with this comment 😃

JamieDanielson avatar Jun 03 '24 20:06 JamieDanielson

/easycla

JamieDanielson avatar Jun 03 '24 20:06 JamieDanielson

I'm not sure why the rest of the status checks / tests are not showing up right now 🤔

JamieDanielson avatar Jun 06 '24 16:06 JamieDanielson

I'm not sure why the rest of the status checks / tests are not showing up right now 🤔

Conflict in the CHANGELOG file. I'm not sure if that is what blocks running the other checks.

trentm avatar Jun 06 '24 22:06 trentm

Conflict in the CHANGELOG file. I'm not sure if that is what blocks running the other checks.

Ah looks like you're right. For some reason I was thinking that wouldn't block tests. I've just pushed up a merge and update to remove the conflict and the rest of the checks are running now.

JamieDanielson avatar Jun 07 '24 15:06 JamieDanielson