opentelemetry-js icon indicating copy to clipboard operation
opentelemetry-js copied to clipboard

Allow optional scope attributes on Meter creation

Open dyladan opened this issue 1 year ago • 2 comments

    Minor: since 1.13.0, the API spec allows optional attributes in the [GetMeter API](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/api.md#get-a-meter):

https://github.com/open-telemetry/opentelemetry-js/blob/d154066354863e8c682b4aa488d79c7e914bf91c/api/src/metrics/MeterProvider.ts#L32

Originally posted by @reyang in https://github.com/open-telemetry/community/issues/1204#issuecomment-1304295098

dyladan avatar Nov 07 '22 13:11 dyladan

I think we can add this parameter after GA in the MeterOptions as a feature update. I propose we change the Title of this issue to something like Allow optional scope attributes on Meter creation and make it part of the Metrics After GA Milestone :slightly_smiling_face:

pichlermarc avatar Nov 07 '22 15:11 pichlermarc

Agreed that this can be a minor feature update after the GA.

See also the spec compliance table row "get_meter accepts attributes.", no language SDK has declared to support the feature yet: https://github.com/open-telemetry/opentelemetry-specification/blob/main/spec-compliance-matrix.md#metrics.

legendecas avatar Nov 07 '22 16:11 legendecas

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Jan 09 '23 06:01 github-actions[bot]