opentelemetry-js icon indicating copy to clipboard operation
opentelemetry-js copied to clipboard

Add http request metrics to either http or express package

Open icco opened this issue 1 year ago • 7 comments

Is your feature request related to a problem? Please describe

While I can figure out RPS from traces, if traces are sampled, this number is wrong.

Describe the solution you'd like to see

I would like to see the metrics described in https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/http-metrics.md exported by one of these two libraries.

Describe alternatives you've considered

Additional context

icco avatar Sep 21 '22 15:09 icco

The newly released http instrumentation should allow you to do this: https://github.com/open-telemetry/opentelemetry-js/pull/3149

vmarchaud avatar Sep 22 '22 19:09 vmarchaud

Oh that's cool. We have that version but haven't seen those metrics yet. I also would like the rest of the metrics in the spec implemented:

Screen Shot 2022-09-22 at 17 09 14

icco avatar Sep 22 '22 21:09 icco

Liked metrics will all be added to http instrumentation, rather than express. I'll move this issue there, @icco.

rauno56 avatar Oct 05 '22 16:10 rauno56

The necessary change has been released in @opentelemetry/instrumentation-http v0.33.0. I'm closing this as completed.

legendecas avatar Oct 08 '22 16:10 legendecas

Just to be clear @legendecas, that change only adds http.client.duration and http.response.duration, the rest of the metrics are still missing.

icco avatar Oct 10 '22 09:10 icco

I will try and put together a PR to add those metrics.

icco avatar Oct 10 '22 09:10 icco

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Dec 19 '22 06:12 github-actions[bot]

This issue was closed because it has been stale for 14 days with no activity.

github-actions[bot] avatar Jan 09 '23 06:01 github-actions[bot]