opentelemetry-js
opentelemetry-js copied to clipboard
Add http request metrics to either http or express package
Is your feature request related to a problem? Please describe
While I can figure out RPS from traces, if traces are sampled, this number is wrong.
Describe the solution you'd like to see
I would like to see the metrics described in https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/http-metrics.md exported by one of these two libraries.
Describe alternatives you've considered
Additional context
The newly released http instrumentation should allow you to do this: https://github.com/open-telemetry/opentelemetry-js/pull/3149
Oh that's cool. We have that version but haven't seen those metrics yet. I also would like the rest of the metrics in the spec implemented:
Liked metrics will all be added to http instrumentation, rather than express. I'll move this issue there, @icco.
The necessary change has been released in @opentelemetry/instrumentation-http v0.33.0. I'm closing this as completed.
Just to be clear @legendecas, that change only adds http.client.duration
and http.response.duration
, the rest of the metrics are still missing.
I will try and put together a PR to add those metrics.
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.
This issue was closed because it has been stale for 14 days with no activity.