opentelemetry-js icon indicating copy to clipboard operation
opentelemetry-js copied to clipboard

OTLP exporters should set User-Agent header as per specification

Open pichlermarc opened this issue 1 year ago • 5 comments

Is your feature request related to a problem? Please describe.

Currently the User-Agent header is not set by our exporters as defined in the specification.

Describe the solution you'd like

The User-Agent Header should be added as OTel OTLP Exporter JavaScript/<exporter version> in all OTLP exporters.

Additional context

Specification: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md#user-agent

pichlermarc avatar Oct 04 '22 06:10 pichlermarc

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Dec 05 '22 06:12 github-actions[bot]

not stale & working on this.

pichlermarc avatar Dec 05 '22 12:12 pichlermarc

@pichlermarc See https://github.com/open-telemetry/opentelemetry-specification/pull/3052 for the corrected format.

arminru avatar Dec 21 '22 12:12 arminru

@pichlermarc any update?

dyladan avatar Dec 21 '22 13:12 dyladan

@pichlermarc See open-telemetry/opentelemetry-specification#3052 for the corrected format.

Thanks!

@pichlermarc any update?

@dyladan No, not yet. I did not have time to work on that for a while. Also, it's not a single line change unfortunately. I'll unassign myself for now in case someone has cycles and wants to pick it up.

Edit: I was not assigned. :sweat_smile: Added back the "up-for-grabs" label.

pichlermarc avatar Dec 21 '22 13:12 pichlermarc

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Feb 27 '23 06:02 github-actions[bot]