opentelemetry-js icon indicating copy to clipboard operation
opentelemetry-js copied to clipboard

TracerProvider should return no-op tracer when shutdown

Open pichlermarc opened this issue 1 year ago • 2 comments

Description

According to the spec a TracerProvider should return no-op tracer when shutdown.

Steps to Reproduce

Test for BasicTracerProvider.test.ts

  describe('.getTracer()', () => {
    it('should return no-op tracer when already shutdown', () => {
      const tracerProvider = new BasicTracerProvider();
      tracerProvider.shutdown();
	  
	  // returned tracer should be no-op, not instance of Tracer (from SDK) 
      assert.ok(!(tracerProvider.getTracer('foo') instanceof Tracer));
    });
  });

Additional Details

Spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#shutdown Link to getTracer() code: https://github.com/open-telemetry/opentelemetry-js/blob/3db10568be4387ef024aa431ca1addef18c2441e/packages/opentelemetry-sdk-trace-base/src/BasicTracerProvider.ts#L93-L101

pichlermarc avatar Aug 30 '22 08:08 pichlermarc

would like to take this up!

sudhanshu-chauhan avatar Sep 30 '22 16:09 sudhanshu-chauhan

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Dec 05 '22 06:12 github-actions[bot]