opentelemetry-js icon indicating copy to clipboard operation
opentelemetry-js copied to clipboard

chore(sdk-trace): replace instrumentation library with instrumentation scope

Open mwear opened this issue 2 years ago • 2 comments

Which problem is this PR solving?

Fixes #2937

Short description of the changes

This PR updates internal references of InstrumentationLibrary to InstrumentationScope. In order to do this in a backwards compatible manner, instrumentationScope was added to ReadableSpan and the instrumentationLibrary property was preserved, but marked as deprecated. Unfortunately, we need both properties in our test fixtures to satisfy the ReadableSpan interface for the time being.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit tests have been updated.

Checklist:

  • [x] Followed the style guidelines of this project
  • [x] Unit tests have been added
  • [x] Documentation has been updated

mwear avatar Aug 25 '22 23:08 mwear

Codecov Report

Merging #3202 (9615372) into main (a5abee6) will increase coverage by 0.02%. The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3202      +/-   ##
==========================================
+ Coverage   93.21%   93.24%   +0.02%     
==========================================
  Files         196      196              
  Lines        6443     6542      +99     
  Branches     1363     1373      +10     
==========================================
+ Hits         6006     6100      +94     
- Misses        437      442       +5     
Impacted Files Coverage Δ
...ental/packages/otlp-transformer/src/trace/index.ts 100.00% <100.00%> (ø)
packages/opentelemetry-sdk-trace-base/src/Span.ts 99.19% <100.00%> (+<0.01%) :arrow_up:
...ackages/opentelemetry-sdk-trace-base/src/Tracer.ts 98.46% <100.00%> (ø)
...entelemetry-instrumentation/src/instrumentation.ts 70.37% <0.00%> (-7.41%) :arrow_down:
...elemetry-sdk-metrics/src/state/MeterSharedState.ts 96.15% <0.00%> (-3.85%) :arrow_down:
...opentelemetry-sdk-metrics/src/view/ViewRegistry.ts 100.00% <0.00%> (ø)
...entelemetry-sdk-metrics/src/export/MetricReader.ts 100.00% <0.00%> (ø)
...telemetry-sdk-metrics/src/state/MetricCollector.ts 100.00% <0.00%> (ø)
...y-sdk-metrics/src/export/AggregationTemporality.ts 100.00% <0.00%> (ø)
...-sdk-metrics/src/state/MeterProviderSharedState.ts 100.00% <0.00%> (ø)
... and 7 more

codecov[bot] avatar Aug 26 '22 00:08 codecov[bot]

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

github-actions[bot] avatar Nov 14 '22 06:11 github-actions[bot]

This PR was closed because it has been stale for 14 days with no activity.

github-actions[bot] avatar Jan 09 '23 06:01 github-actions[bot]