opentelemetry-js
opentelemetry-js copied to clipboard
open-telemetry
Rename `InstrumentationLibrary` -> `InstrumentationScope`
InstrumentationLibrary has been renamed InstrumentationScope in the spec.
We need to find a non-breaking solution to rename it (and associated fields) in the Trace SDK as it already had a 1.0 release. In the Metrics SDK we should do that before GA.
In metrics we can do a simple rename but in traces we have to keep the old name. We can mark the old name @deprecated in the js docs and remove when we do 2.0
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Current progress is that metrics are updated to InstrumentationScope, but traces are not.
I'm unassigning myself for now in case someone else has some cycles and wants to work on it. I'll mark this as never-stale too. :slightly_smiling_face:
It looks like we use scope for the OTLP but not the internal SDK representation. We should definitely do this but it isn't critical priority IMO.
@dyladan can you please clarify what you meant by we use scope for the OTLP? We still see instrumentationLibrary in the OTLP exported by the browser.
@mwear we are going through breaking changes for SDK 2.0 and I saw you are assigned to this issue. Is this something you still want to work on or should I make this up for grabs?
